Added maven compiler and made README clearer#1
Open
WangRyan408 wants to merge 2 commits intoliningalex:mainfrom
Open
Added maven compiler and made README clearer#1WangRyan408 wants to merge 2 commits intoliningalex:mainfrom
WangRyan408 wants to merge 2 commits intoliningalex:mainfrom
Conversation
Author
|
Adding on to this, there is no documentation on what the args are supposed to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not a java guy but your original README is confusing as heck. Calling IraRothPlanner directly assumes that it compiles to a binary but afaik without some special packages and stuff (which I don't see in the pom file) it'll just compile to JAR. Also not sure how the output is supposed to look, ended up getting the following using the example args: